Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a further explanation of ltr and rtl (based on ePub). #109

Merged
merged 10 commits into from
Oct 31, 2024
Merged

Add a further explanation of ltr and rtl (based on ePub). #109

merged 10 commits into from
Oct 31, 2024

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Oct 24, 2024 •
edited by pr-preview bot
Loading

Suggested by w3c/rdf-turtle#75.

Preview | Diff

@gkellogg gkellogg added the spec:editorial Minor issue or proposed change in the specification (markup, typo, informative text) label Oct 24, 2024
@gkellogg gkellogg requested review from afs and iherman October 24, 2024 22:41
afs
afs reviewed Oct 25, 2024
View reviewed changes
spec/index.html Outdated Show resolved Hide resolved
@gkellogg
Copy link
Member Author

Dear I18N people, I want to be sure that the recently added example for natively displaying Arabic RTL seems appropriate and correct.

@gkellogg gkellogg added the i18n-tracker Group bringing to attention of Internationalization, or tracked by i18n but not needing response. label Oct 25, 2024
@gkellogg gkellogg requested a review from afs October 25, 2024 22:44
gkellogg
gkellogg commented Oct 25, 2024
View reviewed changes
spec/index.html Outdated Show resolved Hide resolved
gkellogg
gkellogg commented Oct 25, 2024
View reviewed changes
spec/index.html Outdated Show resolved Hide resolved
@gkellogg gkellogg mentioned this pull request Oct 25, 2024
Closed
@w3cbot w3cbot mentioned this pull request Oct 26, 2024
Open
aphillips
aphillips suggested changes Oct 26, 2024
View reviewed changes
Copy link
Contributor

@aphillips aphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good start, but would suggest leaning on the I18N materials a bit harder.

spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
TallTed
TallTed reviewed Oct 29, 2024
View reviewed changes
spec/index.html Outdated Show resolved Hide resolved
gkellogg and others added 10 commits October 29, 2024 13:13
@gkellogg
Add a further explaination on ltr and rtl (based on ePub).
ef0c93f 
Suggested by w3c/rdf-turtle#75.
@gkellogg @afs
Change description for ltr and rtl.
d9980e0 
Co-authored-by: Andy Seaborne <[email protected]>
@gkellogg
Add example of displaying right-to-left text in its natural order vs …
93e44b5 
…the way it is stored in memory.
@gkellogg
Fix markup errors.
0bd3b8b
@gkellogg
Apply suggestions from code review
ecf192f
@gkellogg @aphillips
Update I18N description of implicit initial text direction
69102f3 
Co-authored-by: Addison Phillips <[email protected]>
@gkellogg @aphillips
Tweak language on left-to-right/right-to-left.
42eff58 
Co-authored-by: Addison Phillips <[email protected]>
@gkellogg
Use I18N-Glossary instead of UAX9 and UAX15 references.
e4a51e7
@gkellogg
Update Arabic exammple to Hebrew.
4a2d2af
@gkellogg @TallTed
bidi isolation
038ffc5 
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@gkellogg gkellogg merged commit e24289d into main Oct 31, 2024
2 checks passed
@gkellogg gkellogg deleted the expand-on-dirLangString branch October 31, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallTed TallTed TallTed left review comments

@aphillips aphillips aphillips approved these changes

@afs afs afs approved these changes

@iherman iherman iherman approved these changes

@hartig hartig hartig approved these changes

Assignees
No one assigned
Labels
i18n-tracker Group bringing to attention of Internationalization, or tracked by i18n but not needing response. spec:editorial Minor issue or proposed change in the specification (markup, typo, informative text)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gkellogg @aphillips @afs @iherman @hartig @TallTed