Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add text about text directionality to the note in rdf:HTML. #107

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Add text about text directionality to the note in rdf:HTML. #107

merged 2 commits into from
Oct 23, 2024

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Oct 22, 2024 •
edited by pr-preview bot
Loading

Fixes #102.

Preview | Diff

@gkellogg gkellogg added the spec:editorial Minor issue or proposed change in the specification (markup, typo, informative text) label Oct 22, 2024
domel
domel requested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@domel domel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... - > …(in the lang attr there is one sign with three dots and in dir there are three separate dots). Let's unify it.

gkellogg
gkellogg commented Oct 22, 2024
View reviewed changes
spec/index.html Outdated Show resolved Hide resolved
@gkellogg gkellogg requested a review from domel October 22, 2024 20:57
@gkellogg gkellogg self-assigned this Oct 22, 2024
iherman
iherman approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the suggested change by @domel

@gkellogg gkellogg merged commit 73bb52d into main Oct 23, 2024
2 checks passed
@gkellogg gkellogg deleted the rdf-html-literal-dir branch October 23, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hartig hartig hartig approved these changes

@iherman iherman iherman approved these changes

@domel domel domel approved these changes

@afs afs afs approved these changes

Assignees

@gkellogg gkellogg

Labels
spec:editorial Minor issue or proposed change in the specification (markup, typo, informative text)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Note on rdf:HTML and directional value
5 participants
@gkellogg @afs @domel @iherman @hartig