-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle not fully active documents when querying Permissions API #249
Conversation
This seems fine by me by intent though @annevk or so should probably review the spec language :) |
@rakina @reillyeon, here is another "not fully active" change 😇 ... I'm wondering if we could coordinate on it? I have a patch ready to land in Gecko, but need support from a second implementer before landing it both here and in Gecko. |
Thanks for doing this! I'm not really familiar with Permissions API, but I'm a bit concerned about not updating the document when it becomes fully active again in this case (Unlike the Geolocation updates in the other PR which seems a bit more OK to drop/leave the document at a stale status), so I've posted in the original issue: #162 (comment) |
c4c66e3
to
613b424
Compare
Thanks! This looks reasonable, and I've filed a Chrome bug for this: https://bugs.chromium.org/p/chromium/issues/detail?id=1238709 |
Thanks @rakina. I'll put together a WTP for this in the meantime. |
Moved to #365 |
…ions API r=johannh Spec change w3c/permissions#249 Differential Revision: https://phabricator.services.mozilla.com/D118932
…ions API r=johannh Spec change w3c/permissions#249 Differential Revision: https://phabricator.services.mozilla.com/D118932
…ions API r=johannh Spec change w3c/permissions#249 Differential Revision: https://phabricator.services.mozilla.com/D118932
…ions API r=johannh Spec change w3c/permissions#249 Differential Revision: https://phabricator.services.mozilla.com/D118932
closes #162
The following tasks have been completed:
Implementation commitment:
CC @johannhof
Preview | Diff