Fix #281: Get rid of the global current pressure state #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakuco
reviewed
Sep 19, 2024
| @@ -1227,8 +1224,7 @@ <h3>Supporting algorithms</h3> | |||
| Let |record:PressureRecord| be |observer|.{{PressureObserver/[[LastRecordMap]]}}[|source|]. | |||
| </li> | |||
| <li> | |||
| If |record|.{{PressureRecord/[[State]]}} is not equal to |state| and [=change in contributing factors is substantial=] | |||
There was a problem hiding this comment.
Is this change related to the rest? It doesn't seem to reference [=current pressure state=].
There was a problem hiding this comment.
It is. This is done on the global value now instead of per observer.
There was a problem hiding this comment.
I see. It'd be good to explain this in the commit/PR message, as it's not immediately clear just by looking at the patch.
rakuco
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff