-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AOM specs #1141
Add AOM specs #1141
Conversation
AVIF had already been added to the list. This adds remaining specs from the Alliance for Open Media related to AV1. Logic also updated to find more info about these specs automatically. Fixes #1088.
the code looks good, but they're all marked as browser specs - I assume this is correct, but is beyond my expertise for at least some of them |
This is useful for AOM specs. The update also makes the regular expression case-insensitive, which will bring a handful of updates to short titles in the list, e.g., dropping "proposal" from the short titles of some TC39 proposals.
The spec actually builds on the film grain synthesis *in* AV1, which should thus be supported by browsers, but its core purpose is to make it reusable in other codecs, and I'm not clear yet that this is being supported anywhere.
Good catch. Fixed by improving rules.
I dropped the film grain synthesis spec from the browser category. Browsers should actually support the underlying feature for AV1 because it is part of the AV1 spec, but the film grain synthesis spec is designed to make the feature agnostic of the codec, and I'm not yet clear that there are plans to support it elsewhere. I kept other specs in the browser category. Browser implementation status is not fully clear, but that is consistent with what we've been doing for some of the MSE and WebCodecs registry entries. |
@@ -79,6 +79,12 @@ describe("compute-shorttitle module", () => { | |||
"Foo Bar"); | |||
}); | |||
|
|||
it("drops '(Draft)' from title", () => { | |||
assertTitle( | |||
"(Draft) Beer", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍻 ☺
CI tests for some unknown reason, but then the update will indeed create a problem as one of the added specs has an "AOM Working Group Draft" status, which is not expected (and not really an official AOM status...). I guess I'm going to add support for AOM statuses right away after all. |
AOM specs will now be flagged with an AOM status, which can be one of "Draft Deliverable" or "Final Deliverable". There is unfortunately no good way to detect that an AOM is a "Final Deliverable", this has to be specified in `specs.json`. The code now also automatically creates a `release` property when the canonical URL of an AOM spec is a PDF. Now, as far as I can tell, the main AV1 spec is the only one that points at its PDF version as being the authoritative representation. Other final deliverables do not say anything about the published PDF. I'm sticking to the HTML URLs as a result.
I also added support for using the PDF URL as the canonical and release URL for the AV1 spec. It's not clear to me that the PDF version is the canonical representation of the other final deliverables, so I propose to stick to the HTML versions instead, now correctly flagged as "Final Deliverable". The RTP spec remains a "Draft Deliverable" because that's what the spec says for now, pending AOMediaCodec/av1-rtp-spec#236 |
AVIF had already been added to the list. This adds remaining specs from the Alliance for Open Media related to AV1.
Logic also updated to find more info about these specs automatically.
Fixes #1088.
A couple of information points that are ok-ish but that could further be improved:
Changes to index.json