Change the guidelines about establishing base direction and mention ALM #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes w3c#8. This addresses both @stevenatkin's comment and @lkimmel's comment. Note that I added "isolated" to the guideline about providing attributes in markup languages. I am tempted to want to add text to make isolating preferred to embedding. This section may need further review.
✅ Deploy Preview for bp-i18n-specdev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aphillips
changed the title
xfq
reviewed
Oct 10, 2024
|
Overall LGTM, but we should probably link to some background information of these characters. We don't seem to have them our website (see w3c/i18n-drafts#602). Maybe somewhere at unicode.org for now? |
Co-authored-by: Fuqiao Xue <[email protected]>
aphillips
commented
Oct 10, 2024
- Fix text to refer to third example - Make appearance of the text go under the HTML markup to avoid wrapping issues - Use `spilloverExample` style for the rendered text so it is pretty
r12a
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8. Fixes #18.
This addresses both @stevenatkin's comment and @lkimmel's comment.
Note that I added "isolated" to the guideline about providing attributes in markup languages. I am tempted to want to add text to make isolating preferred to embedding. This section may need further review.
I also change the title of the section about strong marks, adding some text ("Strong directional marks:").
Preview | Diff