Remove Core-AAM UA requirement to disallow orphaned role context. #2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
spectranaut
requested changes
Jul 18, 2024
cookiecrook
commented
Jul 19, 2024
| <div role="list"> <!-- computedrole returns "list" --> | ||
| <div role="listitem"> <!-- computedrole returns "listitem" in the required context. --></pre | ||
| > | ||
| <pre><div role="listitem"> <!-- Author error: orphaned listitem. computedrole is unspecified. --></pre> |
There was a problem hiding this comment.
Actually, I think I should keep the second example.
Suggested change
| <pre><div role="listitem"> <!-- Author error: orphaned listitem. computedrole is unspecified. --></pre> | |
| <pre> | |
| <div role="listitem"> <!-- Author error: orphaned listitem. computedrole is unspecified. --> | |
| <div role="list"> <!-- computedrole returns "list" --> | |
| <div role="listitem"> <!-- computedrole returns "listitem" in the appropriate context. --></pre> |
Comment on lines
+554
to
+555
| in scenarios deemed by the implementation to be harmless. This unspecified permissiveness in how engines treat author role usage errors is occasionally overridden for a specific role in | ||
| other specs such as [[HTML-AAM]]. |
There was a problem hiding this comment.
Suggested change
| in scenarios deemed by the implementation to be harmless. This unspecified permissiveness in how engines treat author role usage errors is occasionally overridden for a specific role in | |
| other specs such as [[HTML-AAM]]. | |
| in scenarios deemed by the implementation to be harmless. Please note that this permissiveness in how engines treat author role errors might be overridden in a language-specific mapping document such as [[HTML-AAM]]. |
There was a problem hiding this comment.
@spectranaut The Prettier bot broke the thread (because of the line breaks it needlessly added) but this is in response to your feedback suggestion.
There was a problem hiding this comment.
Ok, this seems better to me!
spectranaut
approved these changes
Jul 22, 2024
Comment on lines
+554
to
+555
| in scenarios deemed by the implementation to be harmless. This unspecified permissiveness in how engines treat author role usage errors is occasionally overridden for a specific role in | ||
| other specs such as [[HTML-AAM]]. |
There was a problem hiding this comment.
Ok, this seems better to me!
scottaohara
approved these changes
Jul 23, 2024
|
@cookiecrook if you include your proposed changes I will land! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Core-AAM UA requirement to disallow orphaned role context.
Closes #2166