Update text node definition #2274
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jnurthen
reviewed
Jul 18, 2024
smockle
reviewed
Jul 18, 2024
accname/index.html
Outdated
| @@ -285,8 +285,8 @@ <h2>Name and Description</h2> | |||
| </dd> | |||
| <dt>contents</dt> | |||
| <dd> | |||
| name is generated from the Text [=nodes=] associated with the [=element=]. Although this may be allowed in addition to "author" in some <a class="termref">roles</a>, "content" is used only | |||
| if higher priority "author" features are not provided. Priority is defined by the <a href="#mapping_additional_nd_te">text equivalent computation</a> algorithm. | |||
| name is generated from the [=exclusive Text node|text node=] associated with the [=element=]. Although this may be allowed in addition to "author" in some <a class="termref">roles</a>, | |||
There was a problem hiding this comment.
This changes from “the Text nodes” (plural) to “the text node” (singular)—is that intended? An accessible name can be generated from multiple text nodes.
For example, this URL—
data:text/html,<h1>Hello, <!--COMMENT-->world!</h1>
—plus this JavaScript—
getAccessibleName(document.querySelector("h1"))
// 'Hello, world!'
document.querySelector("h1").childNodes
// NodeList(3) [text, comment, text]There was a problem hiding this comment.
Agreed "text nodes" should be plural, thank you @smockle. This does introduce inconsistency for the ReSpec linking; aliases are strongly discouraged (let alone differently aliased links pointing to the same thing) so curious if anyone disagrees with simply making it plural while in other cases we use "text node" as the link.
Changed as part of bde4f90.
spectranaut
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes accname #212
Update text node definition using the DOM exclusive text node definition.