Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editorial: remove vague "meaningful" and parenthetical example #2069

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pkra
Copy link
Member

@pkra pkra commented Oct 20, 2023

Following up on #2062.
Closes #2068

In this negation, it seems very vague (what is non-meaningful-but-not-empty alt?) and I think a clear "SHOULD NOT add alt" is better.

Otherwise, if there's a use case for "non-meaningful text alternative" then perhaps this can be added to the parenthetical example.

To further reduce confusion, the parenthical example using an empty alt attribute was also removed.


Preview | Diff

@pkra pkra added the editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo label Oct 20, 2023
index.html Outdated Show resolved Hide resolved
@pkra pkra changed the title editorial: remove vague "meaningful" editorial: remove vague "meaningful" and parenthetical example Oct 25, 2023
@pkra pkra requested a review from jnurthen October 27, 2023 14:10
index.html Outdated Show resolved Hide resolved
Copy link
Member

@jnurthen jnurthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we really don't intend to allow alt="" on role="none" then fine - but I'm not sure that is the intent. If it is then we need to change the example too.

@pkra
Copy link
Member Author

pkra commented Nov 2, 2023

if we really don't intend to allow alt="" on role="none" then fine - but I'm not sure that is the intent. If it is then we need to change the example too.

E.g., nu validator flags it as error "An img element which has an alt attribute whose value is the empty string must not have a role attribute."

@pkra pkra added the spec:aria label Jun 14, 2024
Co-authored-by: James Nurthen <[email protected]>
Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit 4a7c3c7
🔍 Latest deploy log https://app.netlify.com/sites/wai-aria/deploys/679b31982869c30008c89c3f
😎 Deploy Preview https://deploy-preview-2069--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pkra
Copy link
Member Author

pkra commented Jan 30, 2025

@jnurthen I've added your suggestion. Can I merge this?

@pkra pkra requested a review from jnurthen January 30, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo spec:aria
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What is non-meaningful text alternative?
4 participants