-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editorial: remove vague "meaningful" and parenthetical example #2069
base: main
Are you sure you want to change the base?
Conversation
Following up on #2062.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we really don't intend to allow alt="" on role="none" then fine - but I'm not sure that is the intent. If it is then we need to change the example too.
E.g., nu validator flags it as error "An img element which has an alt attribute whose value is the empty string must not have a role attribute." |
Co-authored-by: James Nurthen <[email protected]>
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@jnurthen I've added your suggestion. Can I merge this? |
Following up on #2062.
Closes #2068
In this negation, it seems very vague (what is non-meaningful-but-not-empty alt?) and I think a clear "SHOULD NOT add alt" is better.
Otherwise, if there's a use case for "non-meaningful text alternative" then perhaps this can be added to the parenthetical example.
To further reduce confusion, the parenthical example using an empty alt attribute was also removed.
Preview | Diff