Editorial: Provide examples of types of menus #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spectranaut
approved these changes
Oct 12, 2023
Co-authored-by: Valerie Young <[email protected]>
pkra
approved these changes
Oct 13, 2023
mcking65
requested changes
Oct 18, 2023
|
I would love to see this PR move forward. |
imo, the prior suggestions went a bit beyond scope for what I think was needed for this update. So I pulled in some of the suggested updates, but not all.
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
ping @mcking65, @cookiecrook , @curtbellew (since you were all signed up to review) to get at least one more reviewer so this can be merged, please. |
jnurthen
changed the title
scottaohara
commented
Dec 11, 2024
cookiecrook
approved these changes
Dec 19, 2024
Co-authored-by: James Craig <[email protected]>
Co-authored-by: James Craig <[email protected]>
pkra
added
editorial
github-actions bot
added a commit
that referenced
this pull request
Feb 6, 2025
SHA: 67e53b2 Reason: push, by spectranaut Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1084
Updated menu content to attempt to help differentiate
menuandmenubar, per the request of the original issue.Preview | Diff