Handle errors from JSON serialization. #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
npm1
approved these changes
Oct 28, 2024
github-actions bot
added a commit
that referenced
this pull request
Oct 28, 2024
SHA: 026dbaa Reason: push, by cbiesinger Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
timcappalli
reviewed
Oct 28, 2024
| @@ -1208,6 +1208,7 @@ To <dfn>fetch an identity assertion</dfn> given a {{USVString}} | |||
| 1. If |provider|'s {{IdentityProviderRequestOptions/params}} is not empty: | |||
| 1. Let |json| be the result of [=serializing a JavaScript value to a JSON string=] | |||
| with |provider|'s {{IdentityProviderRequestOptions/params}}. | |||
| 1. If serializing threw an exception, return failure. | |||
There was a problem hiding this comment.
should this be "through" instead of "threw"?
There was a problem hiding this comment.
should this be "through" instead of "threw"?
Nope. "Threw" is a past tense of "throw".
github-actions bot
added a commit
to mattdanielbrown/WebID
that referenced
this pull request
Oct 29, 2024
SHA: 026dbaa Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff