Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors from JSON serialization. #666

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

cbiesinger
Copy link
Collaborator

@cbiesinger cbiesinger commented Oct 25, 2024

Copy link
Collaborator

@samuelgoto samuelgoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbiesinger cbiesinger merged commit 026dbaa into w3c-fedid:main Oct 28, 2024
2 checks passed
@cbiesinger cbiesinger deleted the params branch October 28, 2024 19:02
github-actions bot added a commit that referenced this pull request Oct 28, 2024
SHA: 026dbaa
Reason: push, by cbiesinger

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@@ -1208,6 +1208,7 @@ To <dfn>fetch an identity assertion</dfn> given a {{USVString}}
1. If |provider|'s {{IdentityProviderRequestOptions/params}} is not empty:
1. Let |json| be the result of [=serializing a JavaScript value to a JSON string=]
with |provider|'s {{IdentityProviderRequestOptions/params}}.
1. If serializing threw an exception, return failure.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be "through" instead of "threw"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be "through" instead of "threw"?

Nope. "Threw" is a past tense of "throw".

github-actions bot added a commit to mattdanielbrown/WebID that referenced this pull request Oct 29, 2024
SHA: 026dbaa
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants