Specify the webdriver command to open terms of service and privacy po… #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbiesinger
added a commit
to cbiesinger/selenium
that referenced
this pull request
Jun 3, 2024
This builds on commit 7ad44ee The specification for clickdialogbutton is here: https://fedidcg.github.io/FedCM/#webdriver-clickdialogbutton The version that takes an index is specified here: w3c-fedid/FedCM#610 Bug SeleniumHQ#12088
7 tasks
npm1
reviewed
Jun 4, 2024
| 1. If |dialogButton| is "`TermsOfService`" or "`PrivacyPolicy`": | ||
| 1. If no FedCM dialog is currently open or the dialog is not a dialog that | ||
| lets a user select an account, return a [=error|WebDriver error=] with | ||
| [=error code=] [=no such alert=]. |
There was a problem hiding this comment.
Is this the right error code?
There was a problem hiding this comment.
It's the code I've been using for all the webdriver commands. It seemed close enough and I wanted to avoid defining a new error code.
npm1
approved these changes
Jun 4, 2024
cbiesinger
added a commit
to cbiesinger/selenium
that referenced
this pull request
Jun 4, 2024
This builds on commit 7ad44ee The specification for clickdialogbutton is here: https://fedidcg.github.io/FedCM/#webdriver-clickdialogbutton The version that takes an index is specified here: w3c-fedid/FedCM#610 Bug SeleniumHQ#12088
cbiesinger
added a commit
to cbiesinger/selenium
that referenced
this pull request
Jun 4, 2024
This builds on commit 7ad44ee The specification for clickdialogbutton is here: https://fedidcg.github.io/FedCM/#webdriver-clickdialogbutton The version that takes an index is specified here: w3c-fedid/FedCM#610 Bug SeleniumHQ#12088
cbiesinger
added a commit
to cbiesinger/selenium
that referenced
this pull request
Jun 4, 2024
This builds on commit 7ad44ee The specification for clickdialogbutton is here: https://fedidcg.github.io/FedCM/#webdriver-clickdialogbutton The version that takes an index is specified here: w3c-fedid/FedCM#610 Bug SeleniumHQ#12088
cbiesinger
added a commit
to cbiesinger/selenium
that referenced
this pull request
Jun 5, 2024
This builds on commit 7ad44ee The specification for clickdialogbutton is here: https://fedidcg.github.io/FedCM/#webdriver-clickdialogbutton The version that takes an index is specified here: w3c-fedid/FedCM#610 Bug SeleniumHQ#12088
cbiesinger
force-pushed
the
webdriver2
branch
from
460e396
to
63259a0
Compare
npm1
approved these changes
Sep 12, 2024
|
The change was reformatting and also changing the error to invalid selector (from invalid argument) here: |
|
@bvandersloot-mozilla could you take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…licy
Fixes #627
Preview | Diff