-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a dictionary of event args/data to Event type for easier access to variables #60
Open
kibagateaux
wants to merge
25
commits into
vyperlang:master
Choose a base branch
from
kibagateaux:fix/event-data-access
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
48641f5
add key-value pair of event variable name to data emitted to all boa.…
kibagateaux 9c1f958
move all Event type instantiation to decode_logs
kibagateaux ecbb5be
generate Event.args_map on request and cache instead of instaniating …
kibagateaux 481b7f5
refactor for less code change
kibagateaux b25388e
use pre-commit hook
kibagateaux 5ee6d62
fix formatting issues
kibagateaux ee50b01
return typed event data in args_map
kibagateaux 7f6f671
update with pr comments and run pre-commit
kibagateaux 813e0e6
add initial event tests
kibagateaux d36cbda
simplify tests
kibagateaux 0c65895
remove chacing from event.ordered_args and update tests
kibagateaux 0a35685
Merge branch 'master' of https://github.com/vyperlang/titanoboa
kibagateaux 3385a34
improve state machine test
charles-cooper a9a710f
move some test directories around
charles-cooper 3697e04
remove dead member variable
charles-cooper 96cdb93
fix lint
charles-cooper 43bfedc
add key-value pair of event variable name to data emitted to all boa.…
kibagateaux f4f0c90
move all Event type instantiation to decode_logs
kibagateaux 2169b86
add initial event tests
kibagateaux 4b960e7
simplify tests
kibagateaux dca7546
remove chacing from event.ordered_args and update tests
kibagateaux c027156
simplify and clean up event tests
kibagateaux 5a3dc46
move event test out of strategies
kibagateaux 1a2fc06
bump vyper version and update event tests for compatability
kibagateaux 7dea3c3
update event tests to use actual contract event emissions
kibagateaux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it is a cached property, I’d just call it something else other than a getter. ‘ordered_args’ is good enough.