feat: namedtuple decoding for vvmcontract structs #356
+255
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for item_abi in event_abi["inputs"]: | ||
| is_topic = item_abi["indexed"] | ||
| assert isinstance(is_topic, bool) | ||
| if not is_topic: |
There was a problem hiding this comment.
double negatives are hard to read
boa/contracts/abi/abi_contract.py
Outdated
|
|
||
| decoded_args = abi_decode(args_selector, data) | ||
|
|
||
| t_i = 0 |
There was a problem hiding this comment.
topic_index and arg_index would be much easier to read
| ret[event_id] = event_abi | ||
| return ret | ||
|
|
||
| def decode_log(self, log_entry): |
There was a problem hiding this comment.
this function does too many things imo it should be splitted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
handle_error()in VVMDeployer.deploy() to properly raise BoaErrors that occur in the ctorHow I did it
How to verify it
Description for the changelog
Cute Animal Picture