feat: Etherscan contract verification #330
Conversation
boa/verifiers.py
Outdated
| wait_time = backoff | ||
| while datetime.now() < timeout: | ||
| if result := predicate(): | ||
| return result |
There was a problem hiding this comment.
so it could be used with more than just bools (but yeah I know you don't like truthiness)
There was a problem hiding this comment.
So the value is actually used to wait until the contract is created:
Line 104 in a83112e
| response.raise_for_status() | ||
| response_json = response.json() | ||
| if response_json.get("status") == "1": | ||
| return response_json["result"] |
There was a problem hiding this comment.
yes definitely, that's the identifier
boa/verifiers.py
Outdated
| ) | ||
|
|
||
|
|
||
| def _wait_until( |
There was a problem hiding this comment.
the indirection here is extremely confusing.
There was a problem hiding this comment.
why not just make it part of the base contract verifier?
There was a problem hiding this comment.
While it is in the verifiers file, it is definitely not specific for contract verification.
Since it doesn't use anything from self I didn't see the point of keeping it in a class
What I did
How I did it
Cute Animal Picture