fixed tests for macos, and duplicate test file causing issues #258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
test_value_error
fails (on MacOS?) #256 by skipping tests if on macos. I'm not sure this is the solution, but if it is, then yay, here is the fix.test_logs
which, when running rawpytest
results in this error:So we just renamed one of them.
How I did it
How to verify it
pytest tests/unitary/
and tests now passpytest tests/unitary/test_logs.py tests/integration/fork/test_logs_weth.py
and tests will pass the issue they ran into before. On the master branch, if you runpytest tests/unitary/test_logs.py tests/integration/fork/test_logs.py
they will fail.Description for the changelog
Cute Animal Picture