Skip to content

Conversation

@dmbaturin
Copy link
Member

Change Summary

Remove the utility found at /opt/vyatta/sbin/exe_action that brings no value and can be dangerous.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Other (please describe): outdated code removal.

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

When I was making other changes in vyatta-cfg, I found a utility I didn't realize existed: https://github.com/vyos/vyatta-cfg/blob/current/src/exe_action.c (installed at /opt/vyatta/sbin/exe_action).

Its apparent goal is to execute commit actions for individual nodes. That was probably a terrible idea even in the days of Vyatta when all config scripts were completely self-contained. Now it can be even more dangerous and can mess up the system state big time, if it works (it doesn't seem to work properly, for better or worse).

In any case, it brings no value to either end users or developers and it's best to remove it.

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

👍
No issues in PR Title / Commit Title

Copy link
Contributor

@jestabro jestabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove utility, as it is unused and easily dangerous.

@natali-rs1985 natali-rs1985 self-requested a review December 8, 2025 09:17
Copy link

@natali-rs1985 natali-rs1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a straightforward removal of a dangerous utility

@dmbaturin dmbaturin merged commit b0fc9ef into vyos:current Dec 8, 2025
6 of 7 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed This PR has been mirrored successfully and removed mirror-initiated This PR initiated for mirror sync workflow labels Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current mirror-completed This PR has been mirrored successfully

Development

Successfully merging this pull request may close these issues.

4 participants