misc: T8066: remove the oudated and dangerous exe_action utility #119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Remove the utility found at
/opt/vyatta/sbin/exe_actionthat brings no value and can be dangerous.Types of changes
Related Task(s)
Related PR(s)
Component(s) name
Proposed changes
When I was making other changes in vyatta-cfg, I found a utility I didn't realize existed: https://github.com/vyos/vyatta-cfg/blob/current/src/exe_action.c (installed at /opt/vyatta/sbin/exe_action).
Its apparent goal is to execute commit actions for individual nodes. That was probably a terrible idea even in the days of Vyatta when all config scripts were completely self-contained. Now it can be even more dangerous and can mess up the system state big time, if it works (it doesn't seem to work properly, for better or worse).
In any case, it brings no value to either end users or developers and it's best to remove it.
How to test
Smoketest result
Checklist: