Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved several typos and grammar errors #13090

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ Note that the new plugin does not handle Vue-specific JSX / TSX transform, which

### Volar Compatibility

2.7 ships improved type definitions so it is no longer necessary to install `@vue/runtime-dom` just for Volar template type inference support. All you need now is the following config in `tsconfig.json`:
2.7 ships improved type definitions, so it is no longer necessary to install `@vue/runtime-dom` just for Volar template type inference support. All you need now is the following config in `tsconfig.json`:

```json
{
Expand All @@ -332,7 +332,7 @@ Vue Devtools 6.2.0 has added support for inspecting 2.7 Composition API state, b

### Bug Fixes

* **compiler-sfc:** should transform non relative paths when base option is present ([008d78b](https://github.com/vuejs/vue/commit/008d78bd7280716d2d70e150e3ed2ac5ee8497f2))
* **compiler-sfc:** should transform non-relative paths when base option is present ([008d78b](https://github.com/vuejs/vue/commit/008d78bd7280716d2d70e150e3ed2ac5ee8497f2))



Expand Down
2 changes: 1 addition & 1 deletion examples/classic/commits/index.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!DOCTYPE html>
<html>
<head>
<title>Vue.js github commits example</title>
<title>Vue.js GitHub commits example</title>
<style>
#demo {
font-family: 'Helvetica', Arial, sans-serif;
Expand Down
2 changes: 1 addition & 1 deletion src/compiler/helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ export function getBindingAttr(

// note: this only removes the attr from the Array (attrsList) so that it
// doesn't get processed by processAttrs.
// By default it does NOT remove it from the map (attrsMap) because the map is
// By default, it does NOT remove it from the map (attrsMap) because the map is
// needed during codegen.
export function getAndRemoveAttr(
el: ASTElement,
Expand Down
2 changes: 1 addition & 1 deletion src/compiler/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { createCompilerCreator } from './create-compiler'
import { CompilerOptions, CompiledResult } from 'types/compiler'

// `createCompilerCreator` allows creating compilers that use alternative
// parser/optimizer/codegen, e.g the SSR optimizing compiler.
// parser/optimizer/codegen, e.g. the SSR optimizing compiler.
// Here we just export a default compiler using the default parts.
export const createCompiler = createCompilerCreator(function baseCompile(
template: string,
Expand Down
6 changes: 3 additions & 3 deletions src/compiler/optimizer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ const genStaticKeysCached = cached(genStaticKeys)

/**
* Goal of the optimizer: walk the generated template AST tree
* and detect sub-trees that are purely static, i.e. parts of
* and detect subtrees that are purely static, i.e. parts of
* the DOM that never needs to change.
*
* Once we detect these sub-trees, we can:
* Once we detect these subtrees, we can:
*
* 1. Hoist them into constants, so that we no longer need to
* create fresh nodes for them on each re-render;
Expand Down Expand Up @@ -75,7 +75,7 @@ function markStaticRoots(node: ASTNode, isInFor: boolean) {
node.staticInFor = isInFor
}
// For a node to qualify as a static root, it should have children that
// are not just static text. Otherwise the cost of hoisting out will
// are not just static text. Otherwise, the cost of hoisting out will
// outweigh the benefits and it's better off to just always render it fresh.
if (
node.static &&
Expand Down