-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct typedef of Route #3901
base: dev
Are you sure you want to change the base?
correct typedef of Route #3901
Conversation
✅ Deploy Preview for vue-router-docs-v3 canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test?
Which files exactly? im kinda new to this so just the files that need to be covered would be great |
You can add it here: https://github.com/vuejs/vue-router/tree/dev/types/test |
Thank you! Will have a look |
is my latest commit what you were looking for in the test? |
Thanks! That should be the test. I will take a look on my next pass over vue router 3. |
Fixes #3566
updated typedef of interface Route from
query: Dictionary<string | (string | null)[]>
toquery: Dictionary<string | null | (string | null)[]>