feat: add keybind(ctrl-p and ctrl-n) for mac platform #3997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch items for mac platform
shellRaining
commented
Jun 29, 2024
| } | ||
| function goRelativeItem(offset: number) { | ||
| const resNum = results.value.length | ||
| selectedIndex.value = (selectedIndex.value + resNum + (offset % resNum)) % resNum |
There was a problem hiding this comment.
when resNum == 0, the selectedIndex.value will be NAN, but this won't crash the script, so I don't add more judgement
shellRaining
commented
Jun 29, 2024
| }) | ||
|
|
||
| const isMac = navigator.platform.toUpperCase().indexOf('MAC') >= 0 |
There was a problem hiding this comment.
navigator.platform has been deprecated, but I want to get whether the modifier key for keyboard shortcuts is the ⌘ command key rather than the ⌃ control key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current appearance is like this, and we can using
ctrl-p/nto navigate for mac platform (and just for local search)this is related with #3853