Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: open code block as modal #3877

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

ToBinio
Copy link

@ToBinio ToBinio commented May 10, 2024

This PR makes it possible to add :modal to a code block.
This adds a button to the code block which makes it possible to open it in a "fullscreen"
modal.
This is useful for cases where the code is very wide and you would need to constantly scroll left and right to see the whole content.
example in the wip fabric wiki

image

@brc-dd
Copy link
Member

brc-dd commented May 10, 2024

Just a heads up though, <dialog> doesn't meet our browser support baseline. So it's unlikely this will be accepted any time soon.

@ToBinio
Copy link
Author

ToBinio commented May 10, 2024

I think it should still be easily doable without <dialog> it would just make the code a bit simpler

Thanks for the quick answer!

@ToBinio ToBinio marked this pull request as ready for review May 11, 2024 12:11
@github-actions github-actions bot added the stale label Jun 23, 2024
@github-actions github-actions bot removed the stale label Jul 17, 2024
@github-actions github-actions bot added the stale label Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants