feat: include the mocks in component globalThis #2120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lmiller1990
reviewed
Jul 6, 2023
| @@ -228,6 +228,8 @@ export function createInstance( | |||
| this.$.setupState[k] = v | |||
| // eslint-disable-next-line no-empty | |||
| } catch (e) {} | |||
| //@ts-ignore Setting an unknown global variable for the component instance | |||
| globalThis[k] = v | |||
There was a problem hiding this comment.
Did this work in Test Utils v1? I actually am surprised this doesn't "just work".
lmiller1990
reviewed
Aug 20, 2023
There was a problem hiding this comment.
Any chance we can add a few more tests around the various globals from Nuxt? I believe they also inject components and a few other things? cc @jrutila
Good point. Nuxt injects through auto imports components. I see if I manage to add that case, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the components beforeCreate we include all the mocks also in
globalThis. That way the mocks are usable also in thescript setuppart of the component.This PR contains the unit test and the solution.
Fixes #2119