Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(RouterView): avoid parent rerenders when possible #2082

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

posva
Copy link
Member

@posva posva commented Dec 15, 2023

Close #1701

Copy link

netlify bot commented Dec 15, 2023

Deploy Preview for vue-router canceled.

Name Link
🔨 Latest commit 1191594
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/657c544dce062d0008af5cae

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.41%. Comparing base (8c73877) to head (db036a5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2082   +/-   ##
=======================================
  Coverage   97.40%   97.41%           
=======================================
  Files          26       26           
  Lines        6055     6068   +13     
  Branches      833      833           
=======================================
+ Hits         5898     5911   +13     
  Misses        155      155           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Narretz
Copy link

Narretz commented Oct 16, 2024

Hi @posva is this still relevant? Perf fixes are always good and I wonder if this fixes a bug I'm seeing ...

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for vue-router ready!

Name Link
🔨 Latest commit db036a5
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/67210ce46fcc5e000832eff5
😎 Deploy Preview https://deploy-preview-2082--vue-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Oct 29, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/vue-router@2082

commit: db036a5

@posva
Copy link
Member Author

posva commented Oct 29, 2024

@Narretz can you try using the pkg-pr published version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 Triaging
Development

Successfully merging this pull request may close these issues.

View Component unnecessarily updates when child route changes
3 participants