Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: output toggle button #279

Merged
merged 9 commits into from
Sep 16, 2024
Merged

fix: output toggle button #279

merged 9 commits into from
Sep 16, 2024

Conversation

lecepin
Copy link
Contributor

@lecepin lecepin commented Aug 26, 2024

  • 增加嵌入风格,isEmbeddedMode。
  • mobile 模式下的, Output/Code 的定制透出。
  • 修复响应式下的切换按钮不工作问题

- 增加嵌入风格,isEmbeddedMode。
- mobile 模式下的, Output/Code 的定制透出。
Copy link

vercel bot commented Aug 26, 2024

@lecepin is attempting to deploy a commit to the vuejs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

pkg-pr-new bot commented Aug 26, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/vuejs/repl/@vue/repl@279

commit: 35570ee

@lecepin
Copy link
Contributor Author

lecepin commented Aug 26, 2024

image

image

嵌入文档等场景使用。

@lecepin lecepin changed the title feat: Adding embed styles feat: Adding embed styles & fix toggle change Aug 28, 2024
@lecepin
Copy link
Contributor Author

lecepin commented Sep 3, 2024

@sxzz 你好,可以帮忙 CR 下么

Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The embed mode is hard to generalize and can be easily achieved with style overrides, so it can be removed.

src/Repl.vue Outdated Show resolved Hide resolved
src/Repl.vue Outdated Show resolved Hide resolved
src/SplitPane.vue Outdated Show resolved Hide resolved
@lecepin lecepin changed the title feat: Adding embed styles & fix toggle change feat: "Output/Code" text customization & fix toggle button not working Sep 9, 2024
@sxzz sxzz merged commit 93051f3 into vuejs:main Sep 16, 2024
1 of 2 checks passed
@sxzz sxzz changed the title feat: "Output/Code" text customization & fix toggle button not working fix: output toggle button Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants