Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): fix the import.meta ts error #2727

Closed
wants to merge 1 commit into from
Closed

Conversation

zhangmo8
Copy link
Contributor

@zhangmo8 zhangmo8 commented Jul 30, 2024

Before:

image

After:

image

Copy link

netlify bot commented Jul 30, 2024

Deploy Preview for pinia-playground canceled.

Name Link
🔨 Latest commit 0911d43
🔍 Latest deploy log https://app.netlify.com/sites/pinia-playground/deploys/66a8c4128af2920007c1ff98

Copy link

netlify bot commented Jul 30, 2024

Deploy Preview for pinia-official canceled.

Name Link
🔨 Latest commit 0911d43
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/66a8c412008a770008d54d7b

@zhangmo8 zhangmo8 changed the title fix: fix the import.meta ts error fix(nuxt): fix the import.meta ts error Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.48%. Comparing base (557f0aa) to head (0911d43).

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #2727      +/-   ##
==========================================
+ Coverage   89.06%   90.48%   +1.42%     
==========================================
  Files          14       14              
  Lines        1335     1335              
  Branches      230      233       +3     
==========================================
+ Hits         1189     1208      +19     
+ Misses        145      126      -19     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@posva
Copy link
Member

posva commented Jul 30, 2024

Thanks but I don't have these errors and it's actually important to use moduleResolution: Bundler (default in nuxt)

@posva posva closed this Jul 30, 2024
@zhangmo8 zhangmo8 deleted the type-fix branch July 30, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants