Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(language-service): don't provide modifier completion for @ and : #5052

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix(language-service): don't provide modifier completion for @ and : #5052

wants to merge 4 commits into from
+28 −23

Conversation

KazariEX
Copy link
Collaborator

No description provided.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 14, 2024 •
edited
Loading

Open in Stackblitz

vue-component-meta

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-meta@5052

@vue/language-core

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-core@5052

vue-component-type-helpers

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@5052

@vue/language-plugin-pug

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@5052

@vue/language-server

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-server@5052

@vue/language-service

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-service@5052

vue-tsc

npm i https://pkg.pr.new/vuejs/language-tools/vue-tsc@5052

@vue/typescript-plugin

npm i https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@5052

commit: 40ebb9a

@KazariEX KazariEX force-pushed the fix/built-in-directive-modifiers-completion branch from 9099456 to 98e0656 Compare December 14, 2024 18:05
@KazariEX KazariEX changed the title fix(language-service): align the completion of built-in directive modifiers with TS behavior fix(language-service): don't provide modifier completion for @ and : Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashishsonavane Ashishsonavane Ashishsonavane approved these changes

@johnsoncodehk johnsoncodehk Awaiting requested review from johnsoncodehk johnsoncodehk is a code owner

@so1ve so1ve Awaiting requested review from so1ve so1ve is a code owner

@zhiyuanzmj zhiyuanzmj Awaiting requested review from zhiyuanzmj zhiyuanzmj is a code owner

@KermanX KermanX Awaiting requested review from KermanX KermanX is a code owner

@davidmatter davidmatter Awaiting requested review from davidmatter davidmatter is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KazariEX @Ashishsonavane