Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugins.md on how to bundle a plugin. #3004

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

luckydonald
Copy link

@luckydonald luckydonald commented Sep 8, 2024

Description of Problem

There exists instructions how to write a plugin,
but not how to prepare or build said plugin for npm.

Proposed Solution

Add link to vite's docs.
I don't think that's a good solution, but it's at least better than what we have now (which is none).

In the long term a detailed instruction would be great,
even better would be if we could have a scaffolding for it, see vuejs/create-vue#565

Additional Information

Copy link

netlify bot commented Sep 8, 2024

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit fa5e884
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/66dcebee7dc40b00083dfcdd
😎 Deploy Preview https://deploy-preview-3004--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! We need to keep the newline between the heading and main text

Comment on lines +139 to +140
### Bundle for NPM
If you further want to build and publish your plugin for others to use, see [Vite's section on Library Mode](https://vitejs.dev/guide/build.html#library-mode).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Bundle for NPM
If you further want to build and publish your plugin for others to use, see [Vite's section on Library Mode](https://vitejs.dev/guide/build.html#library-mode).
### Bundle for NPM
If you further want to build and publish your plugin for others to use, see [Vite's section on Library Mode](https://vitejs.dev/guide/build.html#library-mode).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants