Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reactivity): sync alien-signals 0.4.5 #12570

Draft
wants to merge 1 commit into
base: minor
Choose a base branch
from

Conversation

johnsoncodehk
Copy link
Member

@johnsoncodehk johnsoncodehk commented Dec 17, 2024

SubscriberFlags.Dirtys is no longer required in 0.4.5.

In the past it was used to reset Dirty and ToCheckDirty in checkDirty, but in https://github.com/vuejs/core/pull/12570/files#diff-7d4465613769cc2efcfe55aba539028744753ba9facac7a076b2bb3356eac692L281 flags never contains Dirty, so only ToCheckDirty needs to be reset.

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB (-36 B) 38.1 kB (-5 B) 34.3 kB (+6 B)
vue.global.prod.js 159 kB (-36 B) 57.9 kB (-7 B) 51.5 kB (-88 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.2 kB (-28 B) 18.4 kB (-9 B) 16.9 kB (+54 B)
createApp 55.7 kB (-32 B) 21.5 kB (-3 B) 19.6 kB (-21 B)
createSSRApp 59.8 kB (-32 B) 23.2 kB (-5 B) 21.1 kB
defineCustomElement 60.5 kB (-32 B) 23.1 kB (-4 B) 21 kB (-4 B)
overall 69.7 kB (-36 B) 26.6 kB (-9 B) 24.1 kB (+19 B)

Copy link

pkg-pr-new bot commented Dec 17, 2024

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12570

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12570

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12570

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12570

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12570

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12570

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12570

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12570

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12570

vue

npm i https://pkg.pr.new/vue@12570

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12570

commit: 1a24410

@edison1105
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Dec 19, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt failure success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

@edison1105
Copy link
Member

/ecosystem-ci run nuxt

@vue-bot
Copy link
Contributor

vue-bot commented Dec 19, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
nuxt failure success

@johnsoncodehk johnsoncodehk marked this pull request as draft December 22, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants