Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): boolean casting of props on component instances #12509

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

KazariEX
Copy link
Contributor

@KazariEX KazariEX commented Dec 8, 2024

Copy link

github-actions bot commented Dec 8, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 37.9 kB 34.2 kB
vue.global.prod.js 158 kB 57.8 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.2 kB 18.3 kB 16.8 kB
createApp 55.2 kB 21.3 kB 19.5 kB
createSSRApp 59.3 kB 23.1 kB 21 kB
defineCustomElement 60.1 kB 22.9 kB 20.8 kB
overall 69.1 kB 26.5 kB 24.1 kB

Copy link

pkg-pr-new bot commented Dec 8, 2024

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12509

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12509

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12509

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12509

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12509

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12509

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12509

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12509

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12509

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12509

vue

npm i https://pkg.pr.new/vue@12509

commit: 1825578

@edison1105
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Dec 9, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue failure success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

@edison1105
Copy link
Member

/ecosystem-ci run vite-plugin-vue

@vue-bot
Copy link
Contributor

vue-bot commented Dec 9, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
vite-plugin-vue success success

@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: types language-tools related to vue language-tools labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language-tools related to vue language-tools ready to merge The PR is ready to be merged. scope: types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

defineProps with a TS type and optional boolean has inconsistent behavior
3 participants