fix(compiler-core): using a user-provided key in v-if template element.
#11728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
|
commit: @vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
|
edison1105
reviewed
Aug 28, 2024
| ], | ||
| }, | ||
| }) | ||
| const { |
There was a problem hiding this comment.
I suggest splitting it into two tests
edison1105
added
🍰 p2-nice-to-have
|
I just gave this a try, but it seems that the prop hoisting breaks it: Error: |
edison1105
reviewed
Aug 29, 2024
edison1105
reviewed
Aug 29, 2024
| }) | ||
| }) | ||
|
|
||
| test('template is static key with v-if', () => { |
There was a problem hiding this comment.
Suggested change
| test('template is static key with v-if', () => { | |
| test('template v-if + static key', () => { |
Co-authored-by: edison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #11727
this pr - playground case1
this pr - playground case2