Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-sfc): properly analyze patch flag of vFor + (ref or vnodeHook or dir) #11682

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Aug 22, 2024

close #9239

I’m not sure if this change is correct. Here is my understanding:
When an element uses ref, vnodeHook, or custom directives, the patchFlag should be NEED_PATCH. However, when they are used together with v-for, the patchFlag gets lost.
related commit 1c9a481

playground
playground with this PR

The following problems will be fixed

The last two are from #9240 (comment) created by skirtles-code

@edison1105 edison1105 changed the title fix(compiler-sfc): properly analyze patch flag of vFor fix(compiler-sfc): properly analyze patch flag of vFor + (ref or vnodeHook or dir) Aug 22, 2024
Copy link

github-actions bot commented Aug 22, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 99.1 kB 37.5 kB 33.8 kB
vue.global.prod.js 157 kB (+7 B) 57.3 kB (+9 B) 51 kB (-59 B)

Usages

Name Size Gzip Brotli
createApp 54.5 kB 21.1 kB 19.3 kB
createSSRApp 58.4 kB 22.8 kB 20.8 kB
defineCustomElement 59.1 kB 22.6 kB 20.6 kB
overall 68.1 kB 26.2 kB 23.8 kB

Copy link

pkg-pr-new bot commented Aug 22, 2024

commit: 0cf0c87

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11682

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11682

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11682

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11682

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11682

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11682

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11682

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11682

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11682

vue

pnpm add https://pkg.pr.new/vue@11682

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11682

Open in Stackblitz

@edison1105
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Aug 22, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt failure failure
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working ready for review This PR requires more reviews scope: sfc
Projects
None yet
2 participants