Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-sfc): setup binding has a higher priority than data #11675

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

yangxiuxiu1115
Copy link
Contributor

fix #11674

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 99.1 kB 37.5 kB 33.8 kB
vue.global.prod.js 157 kB 57.3 kB 51 kB

Usages

Name Size Gzip Brotli
createApp 54.5 kB 21.1 kB 19.3 kB
createSSRApp 58.4 kB 22.8 kB 20.8 kB
defineCustomElement 59.1 kB 22.6 kB 20.6 kB
overall 68.1 kB 26.2 kB 23.8 kB

Copy link

pkg-pr-new bot commented Aug 21, 2024

commit: 3e21461

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11675

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11675

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11675

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11675

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11675

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11675

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11675

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11675

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11675

vue

pnpm add https://pkg.pr.new/vue@11675

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11675

Open in Stackblitz

@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: compiler 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. labels Aug 21, 2024
@xieyuschen
Copy link

Hi @edison1105 , could I know is it possible to include this fix in v3.5.0-rc.2? I saw we have just released the v3.5.0-rc.1.

@edison1105
Copy link
Member

@xieyuschen This PR is not a high priority and may not be merged as quickly

@xieyuschen
Copy link

@xieyuschen This PR is not a high priority and may not be merged as quickly

oh i see, but should we consider to prioritise it as anyway it's a bug instead of refinement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged. scope: compiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

created hook doesn't take effect when mixing composition api and options api and composition api occurs first
3 participants