Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): use separate emits caches for components and mixins #11661

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

gcaaa31928
Copy link
Contributor

This seems to be the same issue as #11350, except that in this case, the emits cache is being reused by both mixins and components, which could lead to the emit validation being applied in the wrong context.

However, the fix here is the same: separate the emits cache from the appContext

Copy link

github-actions bot commented Aug 19, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+39 B) 37.7 kB (+20 B) 34 kB (+55 B)
vue.global.prod.js 159 kB (+39 B) 57.6 kB (+12 B) 51.2 kB (-91 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 48.8 kB 18.8 kB 17.2 kB
createApp 55.3 kB (+39 B) 21.2 kB (+6 B) 19.4 kB (-27 B)
createSSRApp 59.3 kB (+39 B) 22.9 kB (+3 B) 20.9 kB (+1 B)
defineCustomElement 60.1 kB (+39 B) 22.8 kB (+8 B) 20.7 kB
overall 69.1 kB (+39 B) 26.3 kB (+3 B) 24 kB (+70 B)

Copy link

pkg-pr-new bot commented Aug 19, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11661

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11661

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11661

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11661

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11661

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11661

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11661

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11661

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11661

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11661

vue

pnpm add https://pkg.pr.new/vue@11661

commit: 01bc263

@edison1105
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Aug 20, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

@edison1105 edison1105 added 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready for review This PR requires more reviews labels Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready for review This PR requires more reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants