Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Suspense): avoid double resolve during patch suspense #11471

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Aug 1, 2024

@edison1105
Copy link
Member Author

/ecosystem-ci run

Copy link

github-actions bot commented Aug 1, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.1 kB (+19 B) 34.5 kB (+9 B) 31.2 kB (+18 B)
vue.global.prod.js 147 kB (+19 B) 54 kB (+10 B) 48.1 kB (+69 B)

Usages

Name Size Gzip Brotli
createApp 49.6 kB 19.5 kB 17.8 kB
createSSRApp 53.2 kB 20.9 kB 19.1 kB
defineCustomElement 51.9 kB 20.2 kB 18.5 kB
overall 63.2 kB (+19 B) 24.5 kB (+9 B) 22.3 kB (+40 B)

@vue-bot
Copy link
Contributor

vue-bot commented Aug 1, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt failure success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success failure
vue-macros failure success
vuetify success success
vueuse success success
vue-simple-compiler success success

@edison1105 edison1105 changed the title fix(Suspense): avoid double resolve if pendingBranch is null fix(Suspense): avoid double resolve during patch suspense Aug 2, 2024
@edison1105 edison1105 marked this pull request as ready for review August 2, 2024 01:42
@edison1105
Copy link
Member Author

/ecosystem-ci run

@edison1105 edison1105 added scope: suspense 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready for review This PR requires more reviews labels Aug 2, 2024
@vue-bot
Copy link
Contributor

vue-bot commented Aug 2, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt failure success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success failure
vue-macros failure success
vuetify success success
vueuse success success
vue-simple-compiler success success

@edison1105
Copy link
Member Author

ecosystem ci failures are not related to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready for review This PR requires more reviews scope: suspense
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suspense.resolve() is called without a pending branch.
2 participants