Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

607 in dom template #608

Merged
merged 5 commits into from
Sep 6, 2023
Merged

607 in dom template #608

merged 5 commits into from
Sep 6, 2023

Conversation

tisma95
Copy link
Collaborator

@tisma95 tisma95 commented Sep 6, 2023 •
edited
Loading

Actions à effectuer :

  • Vérifier que le nombre de lignes supprimées égale le nombre de lignes ajoutées
  • Mettre en cohérence toute référence à la page traduite qui serait présente sur d'autres pages
  • Mettre à jour le lien du menu
  • Lier la PR à une issue
    Closes #

Remarques:

@tisma95 tisma95 self-assigned this Sep 6, 2023
@tisma95 tisma95 linked an issue Sep 6, 2023 that may be closed by this pull request
in-DOM template #607
Closed
@stackblitz
Copy link

stackblitz bot commented Sep 6, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Sep 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-fr ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 8:12pm

tlagoda
tlagoda reviewed Sep 6, 2023
View reviewed changes
src/glossary/index.md Outdated Show resolved Hide resolved
edimitchel
edimitchel approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@edimitchel edimitchel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bon boulot !

@edimitchel edimitchel merged commit 916844f into main Sep 6, 2023
2 checks passed
@edimitchel edimitchel deleted the 607-in-dom-template branch September 6, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlagoda tlagoda tlagoda left review comments

@edimitchel edimitchel edimitchel approved these changes

Assignees

@tisma95 tisma95

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

in-DOM template
3 participants
@tisma95 @edimitchel @tlagoda