Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

601 hoisting #603

Merged
merged 7 commits into from
Sep 8, 2023
Merged

601 hoisting #603

merged 7 commits into from
Sep 8, 2023

Conversation

tisma95
Copy link
Collaborator

@tisma95 tisma95 commented Sep 2, 2023

Actions à effectuer :

  • Vérifier que le nombre de lignes supprimées égale le nombre de lignes ajoutées
  • Mettre en cohérence toute référence à la page traduite qui serait présente sur d'autres pages
  • Mettre à jour le lien du menu
  • Lier la PR à une issue
    Closes #

Remarques:

J'ai gardé le terme hoisting j'ai vu que dans la documentation de vue https://fr.vuejs.org/guide/extras/rendering-mechanism.html#static-hoisting on utilise le terme Hissage à voir si on veut remplacer dans le glossaire hoisting par hissage.

Merci

@tisma95 tisma95 self-assigned this Sep 2, 2023
@tisma95 tisma95 linked an issue Sep 2, 2023 that may be closed by this pull request
@stackblitz
Copy link

stackblitz bot commented Sep 2, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Sep 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-fr ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 8, 2023 6:30pm

src/glossary/index.md Outdated Show resolved Hide resolved
src/glossary/index.md Outdated Show resolved Hide resolved
src/glossary/index.md Show resolved Hide resolved
tlagoda
tlagoda previously approved these changes Sep 3, 2023
Copy link
Collaborator

@tlagoda tlagoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mis à part les commentaires laissés par @edimitchel, je valide!

Co-authored-by: Michel EDIGHOFFER <[email protected]>
src/glossary/index.md Outdated Show resolved Hide resolved
Co-authored-by: Michel EDIGHOFFER <[email protected]>
@tlagoda
Copy link
Collaborator

tlagoda commented Sep 6, 2023

Si tu peux/veux, tu peux t'occuper des 2 issues qui me sont assignées je n'aurais pas l'occasion de les traiter prochainement
Bien joué pour ton travail 👍

tlagoda
tlagoda previously approved these changes Sep 6, 2023
src/glossary/index.md Outdated Show resolved Hide resolved
Co-authored-by: Michel EDIGHOFFER <[email protected]>
@edimitchel edimitchel merged commit 96f0972 into main Sep 8, 2023
2 checks passed
@edimitchel edimitchel deleted the 601-hoisting branch September 8, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hoisting
3 participants