Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix open URL on macOS with SwiftUI #115

Merged
merged 1 commit into from
Jan 18, 2024
+4 −1
Merged

Fix open URL on macOS with SwiftUI #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- Add `GitHubAPI` to get licenses from GitHub API
- Update `AcknowListViewController` to get missing licenses from GitHub API, with new `canFetchLicenseFromGitHub` property to disable this behavior
- Fix open URL on macOS with SwiftUI


## 3.0.1 (24 November 2022)
Expand Down
4 changes: 3 additions & 1 deletion Sources/AcknowList/AcknowListSwiftUI.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,9 @@ public struct AcknowListRowSwiftUIView: View {
else if let repository = acknowledgement.repository,
canOpenRepository(for: repository) {
Button(action: {
#if os(iOS)
#if os(macOS)
NSWorkspace.shared.open(repository)
#elseif os(iOS)
UIApplication.shared.open(repository)
#endif
}) {
Expand Down