Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: sync typescript version #2633

Merged
merged 16 commits into from
Jan 29, 2025
Merged

chore: sync typescript version #2633

merged 16 commits into from
Jan 29, 2025

Conversation

matheusps
Copy link
Contributor

@matheusps matheusps commented Jan 27, 2025 •
edited
Loading

What's the purpose of this pull request?

  • Unify typescript versions for the monorepo
  • All packages are in version 5.3.2
  • Delete the /shared package
  • Delete the /eslint-config package
  • Remove //eslint-disable rules

@matheusps matheusps self-assigned this Jan 27, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 27, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
faststore-site ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2025 5:32pm

@matheusps matheusps changed the base branch from main to chore/core-lint January 27, 2025 18:42
@matheusps matheusps changed the title Chore/ts sync chore:sync typescript version Jan 27, 2025
@matheusps matheusps changed the title chore:sync typescript version chore: sync typescript version Jan 27, 2025
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jan 27, 2025 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@matheusps matheusps marked this pull request as ready for review January 27, 2025 18:49
@matheusps matheusps requested a review from a team as a code owner January 27, 2025 18:49
@matheusps matheusps requested review from lariciamota and pedromtec and removed request for a team January 27, 2025 18:49
@matheusps matheusps requested a review from pedromtec January 29, 2025 13:22
Base automatically changed from chore/core-lint to main January 29, 2025 14:15
eduardoformiga
eduardoformiga approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@eduardoformiga eduardoformiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! ⭐
build and dev worked as expected also in starter.

I'm just a little afraid of updating the ts version to v5 and break the stores that are using v4.
Maybe we also need to align with the education team to create a release note?

@matheusps
Copy link
Contributor Author

@eduardoformiga , In the next PR I will do the CLI check for 5.x version.

@matheusps matheusps merged commit befe398 into main Jan 29, 2025
8 checks passed
@matheusps matheusps deleted the chore/ts-sync branch January 29, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduardoformiga eduardoformiga eduardoformiga approved these changes

@lariciamota lariciamota Awaiting requested review from lariciamota lariciamota is a code owner automatically assigned from vtex/faststore

@pedromtec pedromtec Awaiting requested review from pedromtec

Assignees

@matheusps matheusps

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matheusps @eduardoformiga @pedromtec