feat: Image behavior in ImageGallery #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit da6b008:
|
Gmantiqueira
requested review from
gvc and
ArthurTriis1
and removed request for
a team
|
I don't think customizing it will reflect in the layout as expected. |
Gmantiqueira
force-pushed
the
feat/custom-aspect-ratio
branch
from
5aaa8ff to
c0c514e
Compare
Gmantiqueira
force-pushed
the
feat/custom-aspect-ratio
branch
from
c0c514e to
5aae63b
Compare
lariciamota
approved these changes
Nov 7, 2023
|
@Gmantiqueira Since image position does not work with this scenario, we should remove those examples from the doc. Can you remove it pls 👍 |
hellofanny
approved these changes
Nov 8, 2023
Gmantiqueira
changed the title
Gmantiqueira
force-pushed
the
feat/custom-aspect-ratio
branch
from
fbd7299 to
da6b008
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
As related to #2059, we need more customization in our ImageGallery so we can show the image properly, with a good image position.
We tried to use Aspect Ratio for that customization, but it was breaking our layout and the property
object-fitcan fix that problem properly.Before:
After:
OBS: This might be a braking change - the
imagePositionprop is now deprecate, if you are using it in your implementation you'll need to adapt it.How it works?
This PR makes the aspect ratio customizable by CMS.This PR changes the ImageGallery object-fit property from
covertocontain.How to test it?
https://sfj-8088db8--starter.preview.vtex.app/apple-magic-mouse-99988212/p
Starters Deploy Preview
https://sfj-8088db8--starter.preview.vtex.app/
References