Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vshn docker hub #604

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add vshn docker hub #604

wants to merge 2 commits into from

Conversation

vshnbot
Copy link
Collaborator

@vshnbot vshnbot commented Jan 17, 2025

Summary

  • We have to make sure we can configure registries and repositories for our helm charts in the component. We might want to change the default docker hub registry.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

Link: vshn/appcat#298

@zugao zugao added the minor label Jan 17, 2025
@zugao zugao requested review from a team, Kidswiss, TheBigLee and zugao and removed request for a team January 17, 2025 13:03
Kidswiss
Kidswiss approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@Kidswiss Kidswiss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Maybe it makes sense to put our mirror as default for all the services that pull from docker hub?

Also, please update the name of the PR.

@zugao zugao changed the title PR for appcat on update-appuio-registry Add vshn docker hub Jan 20, 2025
@zugao
Copy link
Contributor

zugao commented Jan 20, 2025

Maybe it makes sense to put our mirror as default for all the services that pull from docker hub?

We discussed last week that for appuio managed it might not work. So I decided to leave default docker hub meanwhile for APPUiO Cloud I overwrite with our vshn registry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kidswiss Kidswiss Kidswiss approved these changes

@TheBigLee TheBigLee Awaiting requested review from TheBigLee TheBigLee was automatically assigned from vshn/schedar

@zugao zugao Awaiting requested review from zugao zugao was automatically assigned from vshn/schedar

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vshnbot @zugao @Kidswiss