-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize Ingress creation, use wildcard cert with OCP apps domain #305
Conversation
a323c63
to
6eb56a4
Compare
7723aa8
to
67142f8
Compare
d07552d
to
23f77bb
Compare
80c9829
to
f6fb4eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR will touch existing services. Make sure you check the crossplane-diff of this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the approval, will merge once I got to verify the diff (unless you guys have been able to do that already) |
Previously, ingresses were (mostly) created using helm values. With this change, ingresses are generated in the common package. Meaning: Ingresses are now explicitly defined and no longer templated. This also allows to properly handle OCP default apps wildcard certs without the need of copy/pasting the same code for each service.
Co-authored-by: Gabriel Saratura <58511627+zugao@users.noreply.github.com>
4b1aa1e
to
79a6ad9
Compare
Summary
sub1.apps...
)sub2.sub1.apps...
)Given an apps domain
example.com
:This affects the following services:
Related PR in
component-appcat
: vshn/component-appcat#623Checklist
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelog