-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CI Pipeline on PRs #221
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this branch needs rebasing :P
do we have example pipeline somewhere where I can check how it behaves in real life?
event.json
Outdated
{ | ||
"action": "opened", | ||
"pull_request": { | ||
"merged": true, | ||
"labels": [ | ||
{ | ||
"name": "bug" | ||
} | ||
] | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this file necessary?
This PR is already using it, you can check all the actions. |
12efaf2
to
6f51327
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6f51327
to
285ab8e
Compare
lgtm, but still please remember about rebasing :D |
285ab8e
to
33cb58c
Compare
33cb58c
to
239dd64
Compare
Can you have another look? I've added the cruft/cookiecutter config as well. |
239dd64
to
e6beb00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems good
e6beb00
to
f2adb72
Compare
f2adb72
to
4bd4aa3
Compare
* Checks for label on PRs * Builds images from the branch * Open new PR on component-appcat with new version added * Will auto tag the release on merge
4bd4aa3
to
6852f81
Compare
Summary
Checklist
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelog