Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI Pipeline on PRs #221

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Improve CI Pipeline on PRs #221

merged 1 commit into from
Sep 3, 2024

Conversation

Kidswiss
Copy link
Contributor

@Kidswiss Kidswiss commented Aug 21, 2024

Summary

  • Checks for label on PRs
  • Builds images from the branch
  • Open new PR on component-appcat with new version added
  • Will auto tag the release on merge

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@Kidswiss Kidswiss added the enhancement New feature or request label Aug 21, 2024
@Kidswiss Kidswiss requested review from a team, TheBigLee, wejdross and zugao and removed request for a team August 26, 2024 06:24
Copy link
Member

@wejdross wejdross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this branch needs rebasing :P
do we have example pipeline somewhere where I can check how it behaves in real life?

event.json Outdated
Comment on lines 1 to 11
{
"action": "opened",
"pull_request": {
"merged": true,
"labels": [
{
"name": "bug"
}
]
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this file necessary?

@Kidswiss
Copy link
Contributor Author

do we have example pipeline somewhere where I can check how it behaves in real life?

This PR is already using it, you can check all the actions.

@Kidswiss Kidswiss force-pushed the add/ci_improvements branch from 12efaf2 to 6f51327 Compare August 26, 2024 10:47
Copy link
Collaborator

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kidswiss Kidswiss force-pushed the add/ci_improvements branch from 6f51327 to 285ab8e Compare August 26, 2024 10:50
@wejdross
Copy link
Member

wejdross commented Aug 26, 2024

lgtm, but still please remember about rebasing :D

@Kidswiss Kidswiss force-pushed the add/ci_improvements branch from 285ab8e to 33cb58c Compare August 26, 2024 12:27
@Kidswiss Kidswiss changed the title Add/ci improvements Improve CI Pipeline on PRs Aug 26, 2024
@Kidswiss Kidswiss force-pushed the add/ci_improvements branch from 33cb58c to 239dd64 Compare August 26, 2024 12:45
@Kidswiss
Copy link
Contributor Author

Can you have another look? I've added the cruft/cookiecutter config as well.

@Kidswiss Kidswiss requested review from wejdross and zugao August 26, 2024 12:51
@Kidswiss Kidswiss force-pushed the add/ci_improvements branch from 239dd64 to e6beb00 Compare August 26, 2024 13:39
Copy link
Collaborator

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good

@Kidswiss Kidswiss force-pushed the add/ci_improvements branch from e6beb00 to f2adb72 Compare September 2, 2024 13:48
@Kidswiss Kidswiss added minor and removed enhancement New feature or request labels Sep 2, 2024
@Kidswiss Kidswiss force-pushed the add/ci_improvements branch from f2adb72 to 4bd4aa3 Compare September 2, 2024 14:19
* Checks for label on PRs
* Builds images from the branch
* Open new PR on component-appcat with new version added
* Will auto tag the release on merge
@Kidswiss Kidswiss force-pushed the add/ci_improvements branch from 4bd4aa3 to 6852f81 Compare September 3, 2024 06:33
@Kidswiss Kidswiss added patch and removed minor labels Sep 3, 2024
@Kidswiss Kidswiss merged commit 2f3d221 into master Sep 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants