Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI Pipeline on PRs #220

Closed
wants to merge 16 commits into from
Closed

Improve CI Pipeline on PRs #220

wants to merge 16 commits into from

Conversation

Kidswiss
Copy link
Contributor

Summary

  • Short summary of what's included in the PR
  • Give special note to breaking changes

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@Kidswiss Kidswiss added the enhancement New feature or request label Aug 20, 2024
Copy link
Collaborator

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a couple of small things. I wonder if you tried to merge the PR when there are no labels or a wrong labels, what would happen?


env:
APP_NAME: appcat
COMPONENT_REPO: kidswiss/component-appcat
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update this

.github/workflows/pr.yml Outdated Show resolved Hide resolved
@Kidswiss
Copy link
Contributor Author

I wonder if you tried to merge the PR when there are no labels or a wrong labels, what would happen?

It fails, but there's also an action that checks that at least one of the labels is there.

Co-authored-by: Gabriel Saratura <[email protected]>
@Kidswiss Kidswiss closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants