Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token refresh jhub #180

Closed
wants to merge 1 commit into from
Closed

Token refresh jhub #180

wants to merge 1 commit into from

Conversation

goseind
Copy link
Member

@goseind goseind commented Jul 24, 2023

ref #21 and subtask #53
dep on #179

This pr extends and modifies the token script for clarity (access token instead of refresh token) and adds a time-based refresh for the access token as set in the client.

@goseind goseind self-assigned this Jul 24, 2023
@goseind goseind added cern-vre-infra Things only related and depandant on our team component/jhub component/rucio labels Jul 24, 2023
@goseind goseind marked this pull request as ready for review July 24, 2023 15:29
@goseind goseind force-pushed the token_refresh_jhub branch from 9eb2048 to ed750eb Compare July 24, 2023 15:30
@goseind goseind marked this pull request as draft July 26, 2023 07:43
Copy link
Member

@garciagenrique garciagenrique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goseind I forgot to review this PR - It was still marked as Draft, though (how do you wanna proceed for the next time ? Should we review even if it's marked as Draft or should we wait until ready ?)

In any case, please adapt the PR with the latest changed of the previous PRs to write the token into the /tmp file.

@goseind
Copy link
Member Author

goseind commented Aug 21, 2023

solved in 8a207aa

@goseind goseind closed this Aug 21, 2023
@goseind goseind deleted the token_refresh_jhub branch August 21, 2023 07:43
@garciagenrique
Copy link
Member

garciagenrique commented Aug 21, 2023

(editing to erase the message) message arrived without knowledge of the last changes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cern-vre-infra Things only related and depandant on our team component/jhub component/rucio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants