-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add undeploy_first
parameter to wildfly_deployment
#259
base: master
Are you sure you want to change the base?
Conversation
Instead of using `cli.update_deploy`, when setting this parameter to `true`, the deployment is undeployed, before being redeployed.
d2ca6f0
to
b9bda18
Compare
TBH, I'm disappointed I couldn't figure out any way to avoid writing this change. I played around with operation-headers => { 'allow-resource-service-restart' => true } but for some reason, when updating my ear, I'd still either have to manually undeploy it first, or restart the whole wildfly server. |
@@ -54,6 +55,11 @@ | |||
end | |||
end | |||
|
|||
newparam(:undeploy_first, :boolean => true, :parent => Puppet::Parameter::Boolean) do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming things is hard! undeploy_first
was the best I came up with. Open to suggestions. :)
@@ -39,7 +40,7 @@ | |||
end | |||
|
|||
newparam(:timeout) do | |||
desc 'Operation timeout. Defaults to 120' | |||
desc 'Operation timeout. Defaults to 300' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completely unrelated, but now the desc
matches the defaultto
below.
Acceptance test failures appear unrelated.
|
@biemond Build is still failing due to an issue downloading Oracle java in the beaker tests. Is this something that you have to fix up on a regular basis? |
Instead of using
cli.update_deploy
, when setting this parameter totrue
, the deployment is undeployed, before being redeployed.