[WIP] Refactor classes postrun_command, prerun_command #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use data-in-modules instead of params.pp * Add header for puppet-strings * Generate file REFERENCE.md
bastelfreak
approved these changes
May 11, 2019
|
Dear @dhoppe, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
jcpunk
reviewed
Jan 10, 2023
| --- | ||
| r10k::include_postrun_command: false | ||
| r10k::postrun_command::ensure: 'present' | ||
| r10k::postrun_command::command: 'deploy environment -p' |
There was a problem hiding this comment.
r10k is showing -p is deprecated, and suggests use of -m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will prepare the module for data-in-modules and provide a REFERENCE.md. Unfortunately this module uses a lot of classes and I need to figure out which one are private. Because some variables are named or used badly, this change will be backwards incompatible and end up in a major release.