Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify packages version detection #703

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Conversation

maxadamo
Copy link
Contributor

Pull Request (PR) description

Simplify package version detection.
The current implementation is too clever, as it tries to replace the logic built in the package manager.
At the same time we may not be able to chase changes in the package manager and we better hand this task over to the package manager.
In other words, if the version number is wrong, the package manager will detect it and fail and we do not need to fail upfront.

This Pull Request (PR) fixes the following issues

Use format:
Fixes #617
Replaces #618

@bastelfreak bastelfreak added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request bug Something isn't working labels Oct 13, 2024
@maxadamo maxadamo merged commit 647a8fc into voxpupuli:master Oct 13, 2024
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ensure not detecting a pip version
2 participants