-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix update for pre-release version #693
base: master
Are you sure you want to change the base?
Fix update for pre-release version #693
Conversation
Well, thinking more about it, it is probably better for me to parse |
9d3e063
to
6a42c5c
Compare
Hi @teluq-pbrideau , we recently merged #696 . can you please rebase? |
6a42c5c
to
9a57ccd
Compare
9a57ccd
to
ac4d332
Compare
ac4d332
to
e85eae5
Compare
I’ve discovered a potential difference when a package have only pre-release version. I’ve tried with the first package i’ve found with this criteria: When package installed with Also, I cannot find a package with pre-release and a previous stable release to test as I did with pip==24.1.b2 |
@kenyon just to make sure you understood my previous comment: |
@teluq-pbrideau thanks for the clarification. I'm not using this functionality of this module, so this doesn't really affect me, but it seems like it's OK if you have to explicitly do something to enable installation of prereleases, even if I know some tools like |
Pull Request (PR) description
Fix the resolution of the latest version from the pip repository, by removing the pre-release version from the list of the latest package available. See #690 for details.
I’ve added a boolean parameterpre_release
.It should be used instead of
install_args => '--pre'
for theensure => latest
to be aware of the version.I chose to add this parameter instead of trying to parse the
install_args
parameter.The new pip version (24.1b2) does not supportnotreallyaversion
as a package version. I used0.0
as replacementEDIT: I’ve reused the version that was changed in master.
This Pull Request (PR) fixes the following issues
Fixes #690