Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native support for storing bind_pw in hiera; ldap_options is now more flexible. #332

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sandynomad
Copy link

There was no intrinsic way to store an encrypted bind password in heira, so added '$postfix::ldap_bind_pw'.

Converted '$postfix::ldap_options' to be optional or a string or an array of strings.

Modified the ldap-aliases.cf template so that ldap_options can be optional / a string / an array of strings, and then rendered in alphabetical order.

Greg Wickham added 2 commits June 1, 2022 21:14
in heira, so add '$postfix::ldap_bind_pw'.

Converted '$postfix::ldap_options' to be optional or a string
or an array of strings.

Modified the ldap-aliases.cf template so that ldap_options can
be optional / a string / an array of strings, and then rendered
in alphabetical order.
@kenyon kenyon changed the title Native support for storing bind_pw in heira; ldap_options is now more flexible. Native support for storing bind_pw in hiera; ldap_options is now more flexible. Jun 1, 2022
@smortex
Copy link
Member

smortex commented May 13, 2023

@sandynomad 👋

This look good, if you are still interested in getting this merged, can you please rebase your changes on top of master?

Rebasing guide

From your work branch, assuming the remote of voxpupuli is named origin:

git fetch origin         # Download the latest code we have here
git rebase origin/master # Move your commits on top of the main branch
# Fix conflicts, see `git status` for what to do next.
git push -f              # Send the changes (-f is required because we re-wrote history)

This PR seems to predate CI and has some conflicts, this would help us move along.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants