Merge pull request #321 from traylenator/rubo

Comply to rubocop 1.22.3

.msync.yml

@@ -2,4 +2,4 @@
 # Managed by modulesync - DO NOT EDIT
 # https://voxpupuli.org/docs/updating-files-managed-with-modulesync/
 
-modulesync_config_version: '4.2.0'
+modulesync_config_version: '5.1.0'

.puppet-lint.rc

@@ -1 +1,3 @@
---relative
+--fail-on-warnings
+--no-parameter_documentation-check
+--no-parameter_types-check

Gemfile

@@ -4,7 +4,7 @@
 source ENV['GEM_SOURCE'] || "https://rubygems.org"
 
 group :test do
-  gem 'voxpupuli-test', '~> 2.5',   :require => false
+  gem 'voxpupuli-test', '~> 5.0',   :require => false
   gem 'coveralls',                  :require => false
   gem 'simplecov-console',          :require => false
   gem 'puppet_metadata', '~> 1.0',  :require => false
@@ -22,7 +22,7 @@ end
 
 group :release do
   gem 'github_changelog_generator', '>= 1.16.1',  :require => false if RUBY_VERSION >= '2.5'
-  gem 'voxpupuli-release', '>= 1.0.2',            :require => false
+  gem 'voxpupuli-release', '>= 1.2.0',            :require => false
   gem 'puppet-strings', '>= 2.2',                 :require => false
 end
 

Rakefile

@@ -1,7 +1,7 @@
 # Managed by modulesync - DO NOT EDIT
 # https://voxpupuli.org/docs/updating-files-managed-with-modulesync/
 
-# Attempt to load voxupuli-test (which pulls in puppetlabs_spec_helper),
+# Attempt to load voxpupuli-test (which pulls in puppetlabs_spec_helper),
 # otherwise attempt to load it directly.
 begin
   require 'voxpupuli/test/rake'

manifests/init.pp

@@ -156,10 +156,12 @@
   String                          $service_ensure      = 'running',
   Boolean                         $service_enabled     =  true,
 ) inherits postfix::params {
-  if (($mastercf_source and $mastercf_content) or
+  if (
+    ($mastercf_source and $mastercf_content) or
     ($mastercf_source and $mastercf_template) or
     ($mastercf_content and $mastercf_template) or
-    ($mastercf_source and $mastercf_content and $mastercf_template)) {
+    ($mastercf_source and $mastercf_content and $mastercf_template)
+  ) {
     fail('mastercf_source, mastercf_content and mastercf_template are mutually exclusive')
   }
 

spec/acceptance/postfix_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper_acceptance'
 
 describe 'postfix class' do

spec/classes/postfix_augeas_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe 'postfix::augeas' do
@@ -20,6 +22,7 @@
                                                                       test_content: %r{Provides unit tests and examples for the <Postfix_Transport> lens.},
                                                                       stock_since: '1.0.0')
       }
+
       it {
         is_expected.to contain_augeas__lens('postfix_virtual').with(ensure: 'present',
                                                                     lens_content: %r{Parses /etc/postfix/virtual},

spec/classes/postfix_mailman_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe 'postfix::mailman' do

spec/classes/postfix_mta_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe 'postfix::mta' do

spec/classes/postfix_satellite_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe 'postfix::satellite' do
@@ -19,6 +21,7 @@ class { 'postfix':
 
       it { is_expected.to compile.with_all_deps }
       it { is_expected.to contain_class('postfix::mta') }
+
       it {
         is_expected.to contain_postfix__virtual('@foo.example.com').with(
           ensure: 'present',